Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TargetLeakageDataCheck to use Woodwork's mutual_information method #1616

Merged
merged 46 commits into from
Jan 14, 2021

Conversation

bchen1116
Copy link
Contributor

fix #927

@bchen1116 bchen1116 self-assigned this Dec 28, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1616 (43b68ea) into main (00eac40) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1616     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18658    18767    +109     
=========================================
+ Hits        18650    18759    +109     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/data_checks/target_leakage_data_check.py 100.0% <100.0%> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <100.0%> (ø)
...ata_checks_tests/test_target_leakage_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00eac40...43b68ea. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks good to me. Left a comment about removing some of the ww conversions and doing a combined one.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but left some comments about reducing time complexity and keeping our original pearson coefficient method via a parameter!

@bchen1116 bchen1116 marked this pull request as ready for review December 29, 2020 23:57
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely like the changes. Good job.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice; left a few more comments and questions, but haven't had the chance to look at everything entirely yet :d

@bchen1116 bchen1116 requested a review from angela97lin January 8, 2021 21:38
@bchen1116 bchen1116 merged commit ecf8765 into main Jan 14, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_927_mutual_info branch May 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label leakage: use mutual information
5 participants