Change TargetLeakageDataCheck to use Woodwork's mutual_information method#1616
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18658 18767 +109
=========================================
+ Hits 18650 18759 +109
Misses 8 8
Continue to review full report at Codecov.
|
jeremyliweishih
left a comment
There was a problem hiding this comment.
Cool looks good to me. Left a comment about removing some of the ww conversions and doing a combined one.
angela97lin
left a comment
There was a problem hiding this comment.
Looking good, but left some comments about reducing time complexity and keeping our original pearson coefficient method via a parameter!
chukarsten
left a comment
There was a problem hiding this comment.
Definitely like the changes. Good job.
angela97lin
left a comment
There was a problem hiding this comment.
Nice nice; left a few more comments and questions, but haven't had the chance to look at everything entirely yet :d
fix #927