Skip to content

Cap scipy<1.6.0 - #1629

Merged
angela97lin merged 2 commits into
mainfrom
1628_scipy_dep_cap
Dec 31, 2020
Merged

Cap scipy<1.6.0#1629
angela97lin merged 2 commits into
mainfrom
1628_scipy_dep_cap

Conversation

@angela97lin

Copy link
Copy Markdown
Contributor

Latest scipy update breaks main (#1628) so capping scipy so we can address separately.

@angela97lin angela97lin self-assigned this Dec 31, 2020
@codecov

codecov Bot commented Dec 31, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1629 (39dc96e) into main (bafd56d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1629   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18177    18177           
=======================================
  Hits        18169    18169           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafd56d...39dc96e. Read the comment docs.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you file an issue to investigate it further?

@angela97lin

Copy link
Copy Markdown
Contributor Author

Yup, filed #1630!

@angela97lin
angela97lin merged commit dba74f2 into main Dec 31, 2020
@angela97lin
angela97lin deleted the 1628_scipy_dep_cap branch January 13, 2021 20:36
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants