-
Notifications
You must be signed in to change notification settings - Fork 89
Adding custom index support for MAPE #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70846c4
to
e35bdb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1641 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18255 18263 +8
=========================================
+ Hits 18247 18255 +8
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 !
y_predicted = y_predicted.values | ||
difference = np.subtract(y_true, y_predicted) | ||
scaled_difference = np.divide(difference, y_true) | ||
return np.abs(scaled_difference).mean() * 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddyaboulton very cool!
The call to .values
converts to a np type -- is that necessary here, or will the first call to one of the np ufuncs do that conversion for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up removing the ufuncs cause calling .values
is all we need!
e35bdb9
to
c732925
Compare
Pull Request Description
Fixes #1634
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.