Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass pipeline params to time series regression baseline estimator #1645

Merged
merged 4 commits into from Jan 5, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1636


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton changed the title 1636 pass pipeline params to time series regression baseline estimator Pass pipeline params to time series regression baseline estimator Jan 5, 2021
@freddyaboulton freddyaboulton added the bug Issues tracking problems with existing features. label Jan 5, 2021
@freddyaboulton freddyaboulton self-assigned this Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1645 (3ae78bc) into main (ea0b3ad) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1645     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18263    18270      +7     
=========================================
+ Hits        18255    18262      +7     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.7% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0b3ad...3ae78bc. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the 1636-pass-pipeline-params-to-baseline branch from d87a743 to 79b6b9e Compare January 5, 2021 16:22
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 ⚓

This could be more of an argument to do #1637 👁️ 👁️

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. Thanks!

@freddyaboulton freddyaboulton merged commit 0757344 into main Jan 5, 2021
@freddyaboulton freddyaboulton deleted the 1636-pass-pipeline-params-to-baseline branch January 5, 2021 17:19
@dsherry dsherry requested review from bchen1116 and removed request for bchen1116 January 5, 2021 17:20
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues tracking problems with existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass gap and max_delay to baseline estimator in AutoMLSearch for time series problems
3 participants