Pass pipeline params to time series regression baseline estimator#1645
Merged
freddyaboulton merged 4 commits intomainfrom Jan 5, 2021
Merged
Pass pipeline params to time series regression baseline estimator#1645freddyaboulton merged 4 commits intomainfrom
freddyaboulton merged 4 commits intomainfrom
Conversation
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18263 18270 +7
=========================================
+ Hits 18255 18262 +7
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1636-pass-pipeline-params-to-baseline
branch
from
d87a743 to
79b6b9e
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
chukarsten,
dsherry and
jeremyliweishih
angela97lin
approved these changes
Jan 5, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
LGTM! 🚢 ⚓
This could be more of an argument to do #1637 👁️ 👁️
jeremyliweishih
approved these changes
Jan 5, 2021
Collaborator
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
Good fix. Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1636
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.