Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting fraud dataset to speed up doc builds #1646

Merged
merged 5 commits into from Jan 5, 2021
Merged

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Jan 5, 2021

Testing to see whether or not limiting the fraud dataset will cause the doc builds to pass

Notebook builds passed here and here, and doc example is here

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1646 (2ba54cf) into main (84b0214) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18270    18270           
=======================================
  Hits        18262    18262           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b0214...2ba54cf. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bchen1116 !!

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@@ -58,7 +58,7 @@
"source": [
"import evalml\n",
"from evalml.utils import infer_feature_types\n",
"X, y = evalml.demos.load_fraud(return_pandas=True)\n",
"X, y = evalml.demos.load_fraud(n_rows=1000, return_pandas=True)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@bchen1116 bchen1116 merged commit d4739cf into main Jan 5, 2021
1 check passed
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_fix_notebooks branch May 13, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants