Remove text_columns parameter from LSA and TextFeaturizer components - #1652
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
========================================
- Coverage 100.0% 99.9% -0.0%
========================================
Files 255 255
Lines 20621 20571 -50
========================================
- Hits 20613 20549 -64
- Misses 8 22 +14
Continue to review full report at Codecov.
|
| X = pd.DataFrame({"numerical": [1, 2, 3, 1, 2], | ||
| "categorical": ["a", "b", "a", "c", "c"], | ||
| "text": ["string one", "another", "text for a column", "text string", "hello world"]}) | ||
| "text": ["string one", "another", "text for a column, this should be a text column!!", "text string", "hello world"]}) |
There was a problem hiding this comment.
Making this longer so that WW automatically detects its a text column. Could also just use infer_feature_types heh
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin I think this looks good!
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Just left a few questions!
| 'LSA(4.75)[1]', | ||
| 'LSA(-1)[0]', | ||
| 'LSA(-1)[1]']) | ||
| 'LSA(-1.0)[0]', |
There was a problem hiding this comment.
Why did this column label become a float versus the original int?
There was a problem hiding this comment.
Good question! I believe it should have been a float to begin with:
However, because we previously asked users to pass in text col names and then use those col names and we previously passed in -1, we got -1 as an int instead.
|
Blocking on #1662 so putting this back as In Progress 😭 |
|
@angela97lin BTW since we decided yesterday that this is not ready to merge, I'm converting this back to a draft. |
…into 1614_remove_text_columns
5 participants
Closes #1614.