Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time issues for doc build on circleci #1654

Merged
merged 25 commits into from
Jan 7, 2021
Merged

Fix time issues for doc build on circleci #1654

merged 25 commits into from
Jan 7, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Jan 6, 2021

partially addresses #1420

Doc build on circleci now takes ~6 minutes, and with the additional tasks that circleci runs, it takes a total of ~8-9 minutes to complete.

This is separate from building docs that we use for our documentation. Will put up a separate PR for fixing ReadTheDocs when we get feedback or find a solution to speed up the RTD build, in which case, will then close #1420.

@bchen1116 bchen1116 self-assigned this Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1654 (1b59ab5) into main (2e4f91f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18485    18485           
=======================================
  Hits        18477    18477           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4f91f...1b59ab5. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as draft January 7, 2021 15:41
"metadata": {},
"outputs": [],
"source": [
"best_pipeline.fit(X_train, y_train)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need to fit best pipelines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@bchen1116 bchen1116 changed the title Fix time issues with ReadTheDocs Fix time issues for doc build on circleci Jan 7, 2021
@bchen1116 bchen1116 marked this pull request as ready for review January 7, 2021 22:01
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 👏

docs/Makefile Show resolved Hide resolved
docs/source/demos/fraud.ipynb Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Show resolved Hide resolved
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 This is awesome! Looks like the old build time was like 15 minutes so this is a big improvement!

docs/source/user_guide/automl.ipynb Show resolved Hide resolved
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, LGTM! 🥳

"metadata": {},
"outputs": [],
"source": [
"best_pipeline.fit(X_train, y_train)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@bchen1116 bchen1116 merged commit aad370f into main Jan 7, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_1420_rtd branch May 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs take a long time to build
4 participants