Fix time issues for doc build on circleci #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 240 240
Lines 18485 18485
=======================================
Hits 18477 18477
Misses 8 8 Continue to review full report at Codecov.
|
bchen1116
commented
Jan 7, 2021
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "best_pipeline.fit(X_train, y_train)" |
Contributor
Author
There was a problem hiding this comment.
No longer need to fit best pipelines
bchen1116
changed the title
bchen1116
requested review from
ParthivNaresh,
angela97lin,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
angela97lin and
dsherry
freddyaboulton
approved these changes
Jan 7, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@bchen1116 This is awesome! Looks like the old build time was like 15 minutes so this is a big improvement!
angela97lin
approved these changes
Jan 7, 2021
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "best_pipeline.fit(X_train, y_train)" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #1420
Doc build on circleci now takes ~6 minutes, and with the additional tasks that circleci runs, it takes a total of ~8-9 minutes to complete.
This is separate from building docs that we use for our documentation. Will put up a separate PR for fixing ReadTheDocs when we get feedback or find a solution to speed up the RTD build, in which case, will then close #1420.