Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update for Mac graphviz #1656

Merged
merged 3 commits into from Jan 7, 2021
Merged

Docs update for Mac graphviz #1656

merged 3 commits into from Jan 7, 2021

Conversation

chukarsten
Copy link
Collaborator

@chukarsten chukarsten commented Jan 6, 2021 •
edited

Needed to update the Mac installation instructions to install graphviz so tests will pass.

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2021 •
edited

Codecov Report

Merging #1656 (babd63c) into main (25ffc82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1656   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18476    18476           
=======================================
  Hits        18468    18468           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ffc82...babd63c. Read the comment docs.

@chukarsten chukarsten marked this pull request as ready for review January 7, 2021 14:48
dsherry
dsherry approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

jeremyliweishih
jeremyliweishih approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🍾

freddyaboulton
freddyaboulton approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chukarsten !

@dsherry dsherry added documentation Improvements or additions to documentation enhancement An improvement to an existing feature. labels Jan 7, 2021
bchen1116
bchen1116 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is what it looks like

angela97lin
angela97lin approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚢

@chukarsten chukarsten merged commit ce43af3 into main Jan 7, 2021
1 check passed
@chukarsten chukarsten deleted the 1655-update_docs_graphviz branch January 7, 2021 16:50
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@angela97lin angela97lin angela97lin approved these changes

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement An improvement to an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@chukarsten @CLAassistant @dsherry @angela97lin @jeremyliweishih @bchen1116 @freddyaboulton