Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graphviz version 0.16 #1657

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Support graphviz version 0.16 #1657

merged 5 commits into from
Jan 7, 2021

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jan 6, 2021

Fixes #1617

New build of the conda version of graphviz 0.16 works with windows, should fix the test errors.

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1657 (2886b7b) into main (ce43af3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1657   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18476    18476           
=======================================
  Hits        18468    18468           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce43af3...2886b7b. Read the comment docs.

@rwedge rwedge marked this pull request as draft January 6, 2021 22:59
@rwedge rwedge marked this pull request as ready for review January 6, 2021 23:19
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwedge thank you for following up on this! 👏

@dsherry
Copy link
Contributor

dsherry commented Jan 7, 2021

@rwedge in order to get check_dependencies_updated_linux green you'll have to update the graphviz version in evalml/tests/dependency_update_check/latest_dependency_versions.txt to 0.16.

@rwedge rwedge merged commit de316b8 into main Jan 7, 2021
@rwedge rwedge deleted the rw-1617-unpin-graphviz branch January 7, 2021 18:12
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate graphviz version 0.16
3 participants