Adding positive_only objectives to non_core_objectives #1661
Conversation
freddyaboulton
changed the title
| assert all([obj not in only_positive for obj in search.additional_objectives]) | ||
|
|
||
|
|
||
| def test_automl_validate_objective(X_y_regression): |
There was a problem hiding this comment.
I don't think we had coverage for this before? Let me know if this is redundant!
There was a problem hiding this comment.
@freddyaboulton Good addition, but why specifically for these 2 objectives?
There was a problem hiding this comment.
Just cause they were non-core but I changed the test to check all non-core objectives hehe!
Codecov Report
@@ Coverage Diff @@
## main #1661 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18485 18503 +18
=========================================
+ Hits 18477 18495 +18
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
negative-target-error
branch
from
33fb266
to
ea9743b
Compare
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
ParthivNaresh,
chukarsten and
jeremyliweishih
|
|
||
| @pytest.mark.parametrize('problem_type', [ProblemTypes.BINARY, ProblemTypes.MULTICLASS, | ||
| ProblemTypes.TIME_SERIES_REGRESSION, ProblemTypes.REGRESSION]) | ||
| def test_automl_does_not_include_positive_only_objectives_by_default(problem_type, X_y_regression): |
| assert all([obj not in only_positive for obj in search.additional_objectives]) | ||
|
|
||
|
|
||
| def test_automl_validate_objective(X_y_regression): |
There was a problem hiding this comment.
@freddyaboulton Good addition, but why specifically for these 2 objectives?
Pull Request Description
Fixes #1660
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.