Skip to content

Allow Objectives to take in list inputs#1663

Merged
bchen1116 merged 11 commits into
mainfrom
bc_1456_list
Jan 11, 2021
Merged

Allow Objectives to take in list inputs#1663
bchen1116 merged 11 commits into
mainfrom
bc_1456_list

Conversation

@bchen1116

Copy link
Copy Markdown
Contributor

fix #1456

Checks to make sure that objectives/automl/pipelines/components can all take in list/np/pd/ww inputs

@bchen1116 bchen1116 self-assigned this Jan 7, 2021
@codecov

codecov Bot commented Jan 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1663 (f4907d3) into main (3fc3497) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1663     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18523    18577     +54     
=========================================
+ Hits        18515    18569     +54     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.0% <ø> (ø)
evalml/objectives/objective_base.py 100.0% <100.0%> (ø)
...ents/estimators/classifiers/lightgbm_classifier.py 100.0% <100.0%> (ø)
...l/pipelines/components/transformers/transformer.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_estimators.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 100.0% <100.0%> (ø)
...alml/tests/objective_tests/test_fraud_detection.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.0% <100.0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc3497...f4907d3. Read the comment docs.

Comment thread evalml/pipelines/components/transformers/transformer.py
@bchen1116 bchen1116 marked this pull request as ready for review January 8, 2021 18:02
@bchen1116 bchen1116 requested review from a team, ParthivNaresh, angela97lin, chukarsten, dsherry, freddyaboulton and jeremyliweishih and removed request for a team, dsherry and freddyaboulton January 8, 2021 18:02

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a possible change with respect to the generation of the different representations of input/target data.

Comment thread evalml/tests/component_tests/test_components.py Outdated
@bchen1116 bchen1116 requested a review from chukarsten January 8, 2021 20:01

@dsherry dsherry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 looks great!

Comment thread evalml/objectives/objective_base.py Outdated
Comment thread evalml/pipelines/components/transformers/transformer.py
Comment thread evalml/tests/component_tests/test_components.py
Comment thread evalml/tests/conftest.py
Comment thread evalml/tests/component_tests/test_components.py Outdated
@bchen1116 bchen1116 requested a review from angela97lin January 8, 2021 21:38

@ParthivNaresh ParthivNaresh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a comment on whether there should be some test coverage for Estimator's predict and predict_proba

Comment thread evalml/tests/component_tests/test_estimators.py
Comment thread evalml/objectives/objective_base.py
@bchen1116 bchen1116 dismissed chukarsten’s stale review January 11, 2021 21:28

addressed changes

@bchen1116 bchen1116 merged commit 2115144 into main Jan 11, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_1456_list branch May 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify input support for lists in objectives/components/pipelines/automl

5 participants