Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to freeze hyperparameters in AutoMLSearch #1676

Merged
merged 33 commits into from Jan 19, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Jan 11, 2021

fix #1625

Design discussion here
Updated documentation here

@bchen1116 bchen1116 self-assigned this Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1676 (39c8551) into main (c321cae) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1676     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         242      242             
  Lines       18942    19055    +113     
=========================================
+ Hits        18934    19047    +113     
  Misses          8        8             
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <100.0%> (ø)
evalml/automl/automl_search.py 99.7% <100.0%> (+0.1%) ⬆️
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c321cae...39c8551. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review January 14, 2021 17:33
@bchen1116 bchen1116 requested review from dsherry, freddyaboulton and angela97lin and removed request for dsherry and freddyaboulton January 14, 2021 18:15
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty solid. I would certainly let someone else take a look at this, because I'm not extremely familiar with the source issue or what's driving this change. But the way you did it looks good.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 Looks great! I like how this handles all the different ways someone might want to "freeze" some hyperparams.

evalml/tests/automl_tests/test_iterative_algorithm.py Outdated Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Show resolved Hide resolved
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, excellent test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy to freeze individual parameters during automl search
4 participants