Update User Guide with Decision Tree Visualization - #1678
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1678 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 242 242
Lines 19273 19273
=======================================
Hits 19265 19265
Misses 8 8
Continue to review full report at Codecov.
|
| roc_curve, | ||
| graph_roc_curve, | ||
| graph_confusion_matrix, | ||
| binary_objective_vs_threshold, |
There was a problem hiding this comment.
Reordered imports alphabetically
There was a problem hiding this comment.
Did flake8 recommend this?
There was a problem hiding this comment.
@freddyaboulton Yeah it weirdly did and it came out of nowhere! One day it wasn't recommending it and the next it was. Correct me if I'm wrong but it makes sense right, as far as alphabetization is concerned?
There was a problem hiding this comment.
Sorting alphabetically makes it look tidier! But your comment about one day not recommending it and the other day recommending it makes me think your version of flake8 got upgraded? Locally, my make lint passed before this change got merged.
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now let's make the pipeline more complex by replacing the Tree with a Forest." |
There was a problem hiding this comment.
Instead of replacing the entire pipeline, which would have resulted in reduced performance and some uglier graphs, I chose to start with a DecisionTree and then change it
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@ParthivNaresh Looks great!!
| roc_curve, | ||
| graph_roc_curve, | ||
| graph_confusion_matrix, | ||
| binary_objective_vs_threshold, |
There was a problem hiding this comment.
Did flake8 recommend this?
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", |
There was a problem hiding this comment.
nit-pick: Maybe we should get rid of the empty cell?
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Output looks good! Just added a comment to change wording for clarity :)
https://feature-labs-inc-evalml--1678.com.readthedocs.build/en/1678/user_guide/model_understanding.html#Tree-Visualization
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now let's make the pipeline more complex by replacing the Tree with a Forest." |
There was a problem hiding this comment.
Bahaha nice! Can we update this to be more specific ex: the Decision Tree pipeline with a Random Forest pipeline or something?
There was a problem hiding this comment.
Also... maybe rather than just stating we'll make it more complex (because why?), maybe we should just introduce it in the next part? I guess as a user, I don't understand what the point is :P
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Doc changes look good!
5 participants
Fixes #1541