Update tuner to allow single value parameters #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1686 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18652 18658 +6
=========================================
+ Hits 18644 18650 +6
Misses 8 8
Continue to review full report at Codecov.
|
bchen1116
commented
Jan 12, 2021
| @@ -129,7 +137,6 @@ def test_skopt_tuner_invalid_parameters_score(): | |||
| tuner.add({'Mock Classifier': {'param a': 0, 'param b': 1.0, 'param c': 'option a'}}, np.inf) | |||
| tuner.add({'Mock Classifier': {'param a': 0, 'param b': 1.0, 'param c': 'option a'}}, None) | |||
| tuner.propose() | |||
| print(random_state) | |||
There was a problem hiding this comment.
remove unnecessary print statements
bchen1116
requested review from
dsherry,
angela97lin,
freddyaboulton,
chukarsten,
jeremyliweishih and
ParthivNaresh
and removed request for
dsherry and
angela97lin
|
It seems you have a exception in grid_search_tuner that is uncovered by some of the tests you dropped. It's only one line but you can find it in the codecov.io coverage changes. |
chukarsten
approved these changes
Jan 12, 2021
chukarsten
suggested changes
Jan 12, 2021
jeremyliweishih
approved these changes
Jan 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step to solve #1625
We want to allow tuners to accept single values as input; however, we will not add these values to the search space. These values are then treated as fixed values. We use this to help with the implementation for #1625