Add infer_feature_types to start.ipynb #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 242 242
Lines 18942 18942
=======================================
Hits 18934 18934
Misses 8 8 Continue to review full report at Codecov.
|
bchen1116
requested review from
freddyaboulton,
angela97lin,
dsherry,
christopherbunn,
chukarsten,
jeremyliweishih and
ParthivNaresh
and removed request for
freddyaboulton
angela97lin
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Left comments on how to clean things up a bit, otherwise LGTM! I'm curious about the runtime and the performance though, and haven't looked at docs. Let's confirm that doc builds don't take too much longer (since fraud is more involved this is likely), and that we don't get terrible results (I just have #616) in mind.
chukarsten
approved these changes
Jan 19, 2021
ParthivNaresh
approved these changes
Jan 19, 2021
angela97lin
reviewed
Jan 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1667
Updated docs here