Skip to content

Fix stacked ensembler n_jobs arg for Iterative Algorithm#1706

Merged
bchen1116 merged 15 commits intomainfrom
bc_1672_iterative
Jan 22, 2021
Merged

Fix stacked ensembler n_jobs arg for Iterative Algorithm#1706
bchen1116 merged 15 commits intomainfrom
bc_1672_iterative

Conversation

@bchen1116
Copy link
Copy Markdown
Contributor

fix #1672

@bchen1116 bchen1116 self-assigned this Jan 19, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1706 (12651da) into main (d96defd) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1706     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         242      242             
  Lines       19143    19174     +31     
=========================================
+ Hits        19135    19166     +31     
  Misses          8        8             
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <ø> (ø)
evalml/pipelines/utils.py 100.0% <100.0%> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d96defd...12651da. Read the comment docs.

Copy link
Copy Markdown
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing this needs is a doctoring update for _make_stacked_ensemble_pipeline(). Looks good though.

Copy link
Copy Markdown
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left comments on adding check for ensemble being run and docstr cleanup.

Copy link
Copy Markdown
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bchen1116 !

@bchen1116 bchen1116 requested a review from angela97lin January 20, 2021 16:54
Copy link
Copy Markdown
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes! One more docstring comment but looks good :)

@bchen1116 bchen1116 merged commit 70c42b1 into main Jan 22, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the bc_1672_iterative branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iterative Algorithm does not created ensemble with correct n_jobs parameter

4 participants