Pin LightGBM version to remove bug from docs #1711
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 242 242
Lines 19075 19075
=======================================
Hits 19067 19067
Misses 8 8 Continue to review full report at Codecov.
|
bchen1116
changed the title
bchen1116
requested review from
dsherry,
angela97lin,
freddyaboulton,
chukarsten,
jeremyliweishih and
ParthivNaresh
There was a problem hiding this comment.
@bchen1116 Looks good! I think the only thing is that we need to remember to uncap this once the latest version is published 😆
| @@ -37,6 +37,7 @@ Release Notes | |||
| * Added labeling to ``graph_confusion_matrix`` :pr:`1632` | |||
| * Rerunning search for ``AutoMLSearch`` results in a message thrown rather than failing the search, and removed ``has_searched`` property :pr:`1647` | |||
| * Changed tuner class to allow and ignore single parameter values as input :pr:`1686` | |||
| * Capped LightGBM version limit to remove bug in docs :pr:`1711` | |||
There was a problem hiding this comment.
Any idea why this is only reproducible in the docs?
There was a problem hiding this comment.
Unsure why, but when I ran locally through Jupyter, I didn't run into this bug, even when switching versions for LightGBM. I can look a little more tomorrow and see if there's a reason though.
There was a problem hiding this comment.
Maybe looking at the entire stack trace will be helpful?
There was a problem hiding this comment.
Updated the more complete stacktrace in the description box. I suspect something in nbsphinx might be causing the bug to appear, but I'm unable to repro it in Jupyter.
|
Filed new issue to track unpinning the version here |
fix #1659
Versions 3.1.0 and above raise the bug we see in the docs, which isn't reproducible elsewhere. The bug fix, which they filed here and addressed here, hasn't been released yet.
Using the current branch to build the docs in circleci (through ssh), our doc build passes without any errors. This suggests that once LightGBM releases a new version, we can unpin the LGBM version and remove the bug.
In comparison, this is what the bug looks like (using LightGBM version 3.1.1)
Updated docs here
EDIT
Here's a stacktrace of the docs during the build:
Looks like the booster update for LGBM fails, causing it to raise this error.
We don't get the same error when running the code locally in Jupyter. We do get the error when building the docs locally, which means it could be an error caused through Sphinx? But I think the easiest solution is to wait for the newest release.