Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVM Estimators #1714

Merged
merged 17 commits into from Jan 29, 2021
Merged

Add SVM Estimators #1714

merged 17 commits into from Jan 29, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Jan 21, 2021

fix #1642

SVM Classifier docs here
SVM Regressor docs here

@bchen1116 bchen1116 self-assigned this Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1714 (fed0ecd) into main (7349632) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1714     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         243      247      +4     
  Lines       19445    19571    +126     
=========================================
+ Hits        19436    19562    +126     
  Misses          9        9             
Impacted Files Coverage Δ
evalml/pipelines/__init__.py 100.0% <ø> (ø)
evalml/pipelines/components/__init__.py 100.0% <ø> (ø)
evalml/pipelines/components/estimators/__init__.py 100.0% <ø> (ø)
...alml/tests/model_family_tests/test_model_family.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 99.6% <ø> (ø)
evalml/model_family/model_family.py 100.0% <100.0%> (ø)
...ines/components/estimators/classifiers/__init__.py 100.0% <100.0%> (ø)
...omponents/estimators/classifiers/svm_classifier.py 100.0% <100.0%> (ø)
...lines/components/estimators/regressors/__init__.py 100.0% <100.0%> (ø)
.../components/estimators/regressors/svm_regressor.py 100.0% <100.0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7349632...fed0ecd. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review January 21, 2021 21:10
Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bchen1116 bchen1116 merged commit eb54a63 into main Jan 29, 2021
@bchen1116
Copy link
Contributor Author

Tracking adding these estimators to AutoMLSearch here

@chukarsten chukarsten mentioned this pull request Feb 1, 2021
@freddyaboulton freddyaboulton deleted the bc_1642_svm branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SVM estimators
3 participants