Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random_state arg from get_pipelines in AutoMLSearch #1719

Merged
merged 11 commits into from
Jan 27, 2021

Conversation

bchen1116
Copy link
Contributor

fix #1638

@bchen1116 bchen1116 self-assigned this Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1719 (e5230ff) into main (476c49b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1719     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         243      243             
  Lines       19435    19445     +10     
=========================================
+ Hits        19426    19436     +10     
  Misses          9        9             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.7% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476c49b...e5230ff. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as draft January 22, 2021 18:03
@bchen1116
Copy link
Contributor Author

Will need to resolve this issue to remove support for np.random.RandomState before coming back to this PR

@bchen1116 bchen1116 marked this pull request as ready for review January 26, 2021 19:01
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 Awesome! 🤩

@@ -2177,3 +2177,16 @@ def test_automl_pipeline_params_kwargs(mock_fit, mock_score, X_y_multi):
if 'Decision Tree Classifier' in row['parameters']:
assert 0.1 < row['parameters']['Decision Tree Classifier']['ccp_alpha'] < 0.5
assert row['parameters']['Decision Tree Classifier']['max_depth'] == 1


@pytest.mark.parametrize("random_state", [0, 1, 9])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh and so clean. Awesome.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍

docs/source/release_notes.rst Outdated Show resolved Hide resolved
automl.search()

for i, row in automl.rankings.iterrows():
if 'Base' not in list(row['parameters'].keys())[0]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O same question as other PR LOL, why the check for Base here :o

Copy link
Contributor Author

@bchen1116 bchen1116 Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseline pipeline isn't initialized with a random_state arg, so we can't check for random state here

@bchen1116 bchen1116 merged commit 06dc212 into main Jan 27, 2021
@chukarsten chukarsten mentioned this pull request Feb 1, 2021
@freddyaboulton freddyaboulton deleted the bc_1638_random branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the random_state argument in get_pipeline
4 participants