-
Notifications
You must be signed in to change notification settings - Fork 91
Remove random_state arg from get_pipelines in AutoMLSearch #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 243 243
Lines 19435 19445 +10
=========================================
+ Hits 19426 19436 +10
Misses 9 9
Continue to review full report at Codecov.
|
|
Will need to resolve this issue to remove support for |
freddyaboulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 Awesome! 🤩
| assert row['parameters']['Decision Tree Classifier']['max_depth'] == 1 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("random_state", [0, 1, 9]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So fresh and so clean. Awesome.
angela97lin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice 👍
| automl.search() | ||
|
|
||
| for i, row in automl.rankings.iterrows(): | ||
| if 'Base' not in list(row['parameters'].keys())[0]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O same question as other PR LOL, why the check for Base here :o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baseline pipeline isn't initialized with a random_state arg, so we can't check for random state here
fix #1638