Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.9 to CircleCI tests #1724

Merged
merged 43 commits into from Mar 15, 2021
Merged

Add python 3.9 to CircleCI tests #1724

merged 43 commits into from Mar 15, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jan 22, 2021

Closes #1263

@ParthivNaresh FYI!

@angela97lin angela97lin marked this pull request as draft January 22, 2021 06:46
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1724 (058e713) into main (96ed697) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1724   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         273      273           
  Lines       22356    22356           
=======================================
  Hits        22350    22350           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ed697...058e713. Read the comment docs.

@@ -18,7 +18,7 @@ clean:

.PHONY: html
html:
$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html $(SPHINXOPTS)
$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html $(SPHINXOPTS) -j 'auto'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, accidentally removed in #1959 so adding back in

@@ -147,7 +147,7 @@ workflows:
- unit_tests:
matrix:
parameters:
python_version: [ "3.7" ]
python_version: [ "3.7", "3.9" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this added here because we rely on 3.8 for codecov?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! We also don't test w/ core dependencies as true

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 888dce8 into main Mar 15, 2021
@angela97lin angela97lin deleted the 1263_python_39_support branch March 15, 2021 18:11
@dsherry dsherry mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test for Python 3.9
4 participants