Conversation
Codecov Report
@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 243 243
Lines 19445 19445
=======================================
Hits 19436 19436
Misses 9 9 Continue to review full report at Codecov.
|
jeremyliweishih
requested review from
angela97lin,
bchen1116,
dsherry and
freddyaboulton
freddyaboulton
approved these changes
Jan 28, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@jeremyliweishih Looks good to me!
angela97lin
approved these changes
Jan 28, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Looks good! Added a comment about doc clarification, we should test whether we still need that or not?
docs/source/install.ipynb
Outdated
| "```\n", | ||
| "\n", | ||
| "For older Python versions (3.6.0 in particular), you must install `pip >= 18.0` and `setuptools > 40.0.0` in order to install evalml.\n", | ||
| "For older Python versions you must install `pip >= 18.0` and `setuptools > 40.0.0` in order to install evalml.\n", |
Contributor
There was a problem hiding this comment.
Do we still need this line? :o Wondering since it seems like from the deletion that we wrote this for 3.6 in particular.
chukarsten
approved these changes
Jan 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712.