Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for py3.6 #1751

Merged
merged 13 commits into from Jan 28, 2021
Merged

Drop support for py3.6 #1751

merged 13 commits into from Jan 28, 2021

Conversation

jeremyliweishih
Copy link
Contributor

Fixes #1712.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1751 (2f6b72b) into main (6f4a55b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         243      243           
  Lines       19445    19445           
=======================================
  Hits        19436    19436           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4a55b...2f6b72b. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review January 27, 2021 22:02
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyliweishih Looks good to me!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a comment about doc clarification, we should test whether we still need that or not?

@@ -16,7 +16,7 @@
"pip install evalml\n",
"```\n",
"\n",
"For older Python versions (3.6.0 in particular), you must install `pip >= 18.0` and `setuptools > 40.0.0` in order to install evalml.\n",
"For older Python versions you must install `pip >= 18.0` and `setuptools > 40.0.0` in order to install evalml.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this line? :o Wondering since it seems like from the deletion that we wrote this for 3.6 in particular.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@jeremyliweishih jeremyliweishih merged commit 7349632 into main Jan 28, 2021
@chukarsten chukarsten mentioned this pull request Feb 1, 2021
@freddyaboulton freddyaboulton deleted the js_1712_36 branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for python 3.6
6 participants