Update clone() for pipelines and components to copy over random state by default
#1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1753 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 247 247
Lines 19598 19574 -24
=========================================
- Hits 19589 19565 -24
Misses 9 9
Continue to review full report at Codecov.
|
angela97lin
commented
Jan 28, 2021
| @@ -440,27 +440,19 @@ def test_clone_init(): | |||
| clf = MockFitComponent(**params) | |||
| clf_clone = clf.clone() | |||
| assert clf.parameters == clf_clone.parameters | |||
|
|
|||
|
|
|||
| def test_clone_random_state(): | |||
There was a problem hiding this comment.
Don't need this test specifically anymore.
angela97lin
commented
Jan 28, 2021
| pipeline_clone = pipeline.clone(random_state=42) | ||
| assert pipeline_clone.random_state == pipeline.random_state | ||
|
|
||
| pipeline = linear_regression_pipeline_class(parameters=parameters, random_state=2) |
There was a problem hiding this comment.
Was duplicated checks? 🤔 Either way, not necessary anymore.
angela97lin
commented
Jan 28, 2021
|
|
||
| def test_nonlinear_clone_init(nonlinear_regression_pipeline_class): | ||
| @pytest.mark.parametrize("is_linear", [True, False]) | ||
| def test_clone_init(is_linear, linear_regression_pipeline_class, nonlinear_regression_pipeline_class): |
There was a problem hiding this comment.
Combined test_clone_init and test_nonlinear_clone_init via parametrize
angela97lin
commented
Jan 28, 2021
|
|
||
| def test_clone_fitted(X_y_binary, logistic_regression_binary_pipeline_class): | ||
| @pytest.mark.parametrize("is_linear", [True, False]) | ||
| def test_clone_fitted(is_linear, X_y_binary, logistic_regression_binary_pipeline_class, nonlinear_binary_pipeline_class): |
There was a problem hiding this comment.
Combined test_nonlinear_clone_fitted and test_clone_fitted via parametrize
angela97lin
requested review from
dsherry,
freddyaboulton,
bchen1116,
chukarsten,
jeremyliweishih and
ParthivNaresh
chukarsten
reviewed
Jan 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1340