Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pyzmq < 22.0.0 #1756

Merged
merged 9 commits into from Jan 28, 2021
Merged

Pin pyzmq < 22.0.0 #1756

merged 9 commits into from Jan 28, 2021

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Jan 28, 2021 •
edited

Testing as our windows unit tests are breaking.

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited

Codecov Report

Merging #1756 (a04c6f4) into main (9b5ff74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1756   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         243      243           
  Lines       19445    19445           
=======================================
  Hits        19436    19436           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5ff74...a04c6f4. Read the comment docs.

@jeremyliweishih jeremyliweishih changed the title Pin Matplotlib at 3.3.3 Pin pyzmq < 22.0.0 Jan 28, 2021
@jeremyliweishih jeremyliweishih marked this pull request as ready for review January 28, 2021 19:29
angela97lin
angela97lin approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, glad this worked! 👍

docs/source/release_notes.rst
@@ -8,6 +8,7 @@ Release Notes
* Added support for ``scikit-learn`` ``v0.24.0`` :pr:`1733`
* Fixes
* Removed ``random_state`` arg from ``get_pipelines`` in ``AutoMLSearch`` :pr:`1719`
* Pinned pyzmq at less than 22.0.0 till we add support :pr:`1756`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I don't really know if this is our issue 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin what would you say here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherry Hmmm, maybe something along the lines of "Pinned pyzmq < 22.0.0 until nbval supports pyzmq == 22.0.0"? It looks like that's where the attempt to install is happening and failing...

dsherry
dsherry approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/source/release_notes.rst
@@ -8,6 +8,7 @@ Release Notes
* Added support for ``scikit-learn`` ``v0.24.0`` :pr:`1733`
* Fixes
* Removed ``random_state`` arg from ``get_pipelines`` in ``AutoMLSearch`` :pr:`1719`
* Pinned pyzmq at less than 22.0.0 till we add support :pr:`1756`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin what would you say here?

@jeremyliweishih jeremyliweishih mentioned this pull request Jan 28, 2021
Closed
@jeremyliweishih jeremyliweishih merged commit 1166ec2 into main Jan 28, 2021
2 checks passed
@jeremyliweishih
Copy link
Contributor Author

@dsherry @chukarsten filed #1759 to unpin this.

@chukarsten chukarsten mentioned this pull request Feb 1, 2021
Merged
@freddyaboulton freddyaboulton deleted the js_pin_mpl branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela97lin angela97lin angela97lin approved these changes

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton

@bchen1116 bchen1116

@chukarsten chukarsten

@ParthivNaresh ParthivNaresh

Assignees

@jeremyliweishih jeremyliweishih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremyliweishih @dsherry @angela97lin