Pin pyzmq < 22.0.0#1756
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 243 243
Lines 19445 19445
=======================================
Hits 19436 19436
Misses 9 9 Continue to review full report at Codecov.
|
jeremyliweishih
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
chukarsten and
freddyaboulton
angela97lin
approved these changes
Jan 28, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Yay, glad this worked! 👍
| * Added support for ``scikit-learn`` ``v0.24.0`` :pr:`1733` | ||
| * Fixes | ||
| * Removed ``random_state`` arg from ``get_pipelines`` in ``AutoMLSearch`` :pr:`1719` | ||
| * Pinned pyzmq at less than 22.0.0 till we add support :pr:`1756` |
Contributor
There was a problem hiding this comment.
lol I don't really know if this is our issue 🤷
Contributor
There was a problem hiding this comment.
@dsherry Hmmm, maybe something along the lines of "Pinned pyzmq < 22.0.0 until nbval supports pyzmq == 22.0.0"? It looks like that's where the attempt to install is happening and failing...
dsherry
approved these changes
Jan 28, 2021
| * Added support for ``scikit-learn`` ``v0.24.0`` :pr:`1733` | ||
| * Fixes | ||
| * Removed ``random_state`` arg from ``get_pipelines`` in ``AutoMLSearch`` :pr:`1719` | ||
| * Pinned pyzmq at less than 22.0.0 till we add support :pr:`1756` |
Closed
Collaborator
Author
|
@dsherry @chukarsten filed #1759 to unpin this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing as our windows unit tests are breaking.