-
Notifications
You must be signed in to change notification settings - Fork 89
Adding section on conda to the contributing guide. #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1771 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 247 247
Lines 19573 19573
=======================================
Hits 19564 19564
Misses 9 9 Continue to review full report at Codecov.
|
4df541c
to
f6d01ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be audited without changing anything? It looks good as is. But if it can, I can run through the steps if it'd be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚢
contributing.md
Outdated
@@ -86,6 +86,25 @@ If your work includes a [breaking change](https://en.wiktionary.org/wiki/breakin | |||
* Description of your breaking change | |||
``` | |||
|
|||
### 4. Updating our conda package | |||
|
|||
Some pull requests, in particular those that add new dependencies, may require editing our conda [package](https://anaconda.org/conda-forge/evalml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update or add new dependencies? :d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
f6d01ec
to
14afe6c
Compare
@chukarsten You can try adding yourself to the list of maintainers by running through the steps! Let me know if we should make any changes hehe |
Don't wait on me @freddyaboulton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🐍 📖
Pull Request Description
Fixes #1620
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.