Skip to content

Adding section on conda to the contributing guide. - #1771

Merged
freddyaboulton merged 3 commits into
mainfrom
1620_conda_dev_guide
Feb 3, 2021
Merged

Adding section on conda to the contributing guide.#1771
freddyaboulton merged 3 commits into
mainfrom
1620_conda_dev_guide

Conversation

@freddyaboulton

Copy link
Copy Markdown
Contributor

Pull Request Description

Fixes #1620


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov

codecov Bot commented Feb 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1771 (14afe6c) into main (1f089b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         247      247           
  Lines       19573    19573           
=======================================
  Hits        19564    19564           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f089b9...14afe6c. Read the comment docs.

@bchen1116 bchen1116 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be audited without changing anything? It looks good as is. But if it can, I can run through the steps if it'd be helpful.

@angela97lin angela97lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Comment thread contributing.md Outdated

### 4. Updating our conda package

Some pull requests, in particular those that add new dependencies, may require editing our conda [package](https://anaconda.org/conda-forge/evalml).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update or add new dependencies? :d

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@freddyaboulton

Copy link
Copy Markdown
Contributor Author

Can this be audited without changing anything? It looks good as is. But if it can, I can run through the steps if it'd be helpful.

@chukarsten You can try adding yourself to the list of maintainers by running through the steps! Let me know if we should make any changes hehe

@chukarsten

Copy link
Copy Markdown
Contributor

Don't wait on me @freddyaboulton

@freddyaboulton
freddyaboulton merged commit 30fac41 into main Feb 3, 2021
@freddyaboulton
freddyaboulton deleted the 1620_conda_dev_guide branch February 3, 2021 15:58

@dsherry dsherry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🐍 📖

@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete FeatureLabs evalml-core-feedstock fork, add conda update dev guide

5 participants