Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release doc to reflect tweak in release process #1787

Merged
merged 2 commits into from Feb 4, 2021

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Feb 4, 2021

RE discussion after standup today: freeze main, run the perf tests, review the results and then do the release.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dsherry !

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1787 (23c173b) into main (07f5d73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         247      247           
  Lines       19679    19679           
=======================================
  Hits        19670    19670           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f5d73...23c173b. Read the comment docs.

@angela97lin angela97lin self-requested a review February 4, 2021 19:20
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 😁

@dsherry
Copy link
Collaborator Author

dsherry commented Feb 4, 2021

Oops I added everyone as "assignee" instead of "reviewer" 😅

Thanks!

@dsherry dsherry merged commit ed6a770 into main Feb 4, 2021
2 checks passed
@dsherry dsherry deleted the ds_release_perf_test_process branch February 4, 2021 19:55
@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants