Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed back arrow on install page docs #1795

Merged
merged 4 commits into from Feb 9, 2021
Merged

fixed back arrow on install page docs #1795

merged 4 commits into from Feb 9, 2021

Conversation

jpcarroll
Copy link
Contributor

@jpcarroll jpcarroll commented Feb 8, 2021

Pull Request Description

Fixes back arrow on install page of the docs

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2021

CLA assistant check
All committers have signed the CLA.

@chukarsten
Copy link
Collaborator

@jpcarroll Thanks for contributing. I'll check this out now.

@gsheni
Copy link
Member

gsheni commented Feb 8, 2021

Docs Preview:

Screenshots

Top of Install Page

Screen Shot 2021-02-08 at 2 16 25 PM

Bottom of Install page

Screen Shot 2021-02-08 at 2 16 21 PM

@chukarsten
Copy link
Collaborator

@gsheni What causes that to appear at the top of the page? I can't see RTD yet, but it looks normal on my locally built version...

@gsheni
Copy link
Member

gsheni commented Feb 8, 2021

@chukarsten that is a ReadTheDocs feature. It adds to the top of the HTML to make sure users know the documentation is for a PR. You won't see it when the docs building locally.

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing! We'd love to have you check out some of our other good first issues.

@dsherry
Copy link
Collaborator

dsherry commented Feb 9, 2021

@jpcarroll thank you for contributing!

Could you please re-push when you get a chance? We just updated our CI so that it will run properly on PRs from forks. The next time you push, the CI should go all-green.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1795 (f48fcb7) into main (e99b460) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         248      248           
  Lines       19871    19871           
=======================================
  Hits        19863    19863           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99b460...f48fcb7. Read the comment docs.

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The "back" button on the install page now says "Home" instead of our entire tagline.

@gsheni you may wanna do the same with woodwork

@dsherry dsherry merged commit 3393a6a into alteryx:main Feb 9, 2021
2 checks passed
@tyler3991
Copy link
Contributor

thanks for contributing @jpcarroll ! We really appreciate it.

@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants