New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed back arrow on install page docs #1795
Conversation
@jpcarroll Thanks for contributing. I'll check this out now. |
Docs Preview: ScreenshotsTop of Install PageBottom of Install page |
@gsheni What causes that to appear at the top of the page? I can't see RTD yet, but it looks normal on my locally built version... |
@chukarsten that is a ReadTheDocs feature. It adds to the top of the HTML to make sure users know the documentation is for a PR. You won't see it when the docs building locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for contributing! We'd love to have you check out some of our other good first issues.
@jpcarroll thank you for contributing! Could you please re-push when you get a chance? We just updated our CI so that it will run properly on PRs from forks. The next time you push, the CI should go all-green. |
Codecov Report
@@ Coverage Diff @@
## main #1795 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 248 248
Lines 19871 19871
=======================================
Hits 19863 19863
Misses 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The "back" button on the install page now says "Home" instead of our entire tagline.
@gsheni you may wanna do the same with woodwork
thanks for contributing @jpcarroll ! We really appreciate it. |
Pull Request Description
Fixes back arrow on install page of the docs