Skip to content

Data Health: Sparsity - #1797

Merged
chukarsten merged 9 commits into
mainfrom
1747-sparsity_check
Feb 9, 2021
Merged

chukarsten merged 9 commits into
mainfrom
1747-sparsity_check

Conversation

@chukarsten

@chukarsten chukarsten commented Feb 8, 2021 •

Copy link
Copy Markdown
Contributor

Implements #1797

@codecov

codecov Bot commented Feb 8, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1797 (d271642) into main (4159d08) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1797     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         248      250      +2     
  Lines       19896    19972     +76     
=========================================
+ Hits        19888    19964     +76     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/data_checks/__init__.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)
evalml/data_checks/sparsity_data_check.py 100.0% <100.0%> (ø)
...ests/data_checks_tests/test_sparsity_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4159d08...d271642. Read the comment docs.

@angela97lin angela97lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooooks great! Added a few comments mostly for cleanup but otherwise, 🚢 !!

Comment thread evalml/data_checks/__init__.py
Comment thread evalml/data_checks/sparsity_data_check.py
Comment thread evalml/data_checks/data_check_message_code.py Outdated
Comment thread evalml/data_checks/sparsity_data_check.py Outdated

@bchen1116 bchen1116 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments on things to fix

Comment thread evalml/data_checks/sparsity_data_check.py
Comment thread evalml/data_checks/sparsity_data_check.py Outdated
Comment thread evalml/data_checks/sparsity_data_check.py
Comment thread evalml/data_checks/sparsity_data_check.py
@chukarsten
chukarsten merged commit 3e8b5a1 into main Feb 9, 2021
@chukarsten
chukarsten deleted the 1747-sparsity_check branch February 9, 2021 20:59
@ParthivNaresh ParthivNaresh mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants