Time Series Binary Thresholding support - #1803
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 248 248
Lines 19871 19896 +25
=========================================
+ Hits 19863 19888 +25
Misses 8 8
Continue to review full report at Codecov.
|
bchen1116
commented
Feb 9, 2021
| * Moving some prs to the right section of the release notes :pr:`1789` | ||
| * Tweak README.md. :pr:`1800` | ||
| * Fixed back arrow on install page docs :pr:`1795` | ||
| * Testing Changes |
Contributor
Author
There was a problem hiding this comment.
Noticed this was missing from the release notes
bchen1116
requested review from
ParthivNaresh,
angela97lin,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
February 9, 2021 16:08
jeremyliweishih
approved these changes
Feb 9, 2021
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
looks goods to me
freddyaboulton
approved these changes
Feb 9, 2021
freddyaboulton
left a comment
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this @bchen1116 ! This looks good to me. I have a small comment on the unit test.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1624
Adding test to check for ts binary thresholding support.
split_dataalready handles splitting TS data.