Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers and estimators preserve custom index #1836

Merged
merged 3 commits into from Feb 12, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1723


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1836 (36980e2) into main (2e561c7) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1836     +/-   ##
=======================================
- Coverage   99.9%   99.8%   -0.1%     
=======================================
  Files        255     255             
  Lines      20608   20655     +47     
=======================================
+ Hits       20586   20607     +21     
- Misses        22      48     +26     
Impacted Files Coverage Δ
...components/transformers/encoders/target_encoder.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_components.py 99.2% <100.0%> (-0.8%) ⬇️
...valml/tests/component_tests/test_target_encoder.py 100.0% <100.0%> (ø)
evalml/tests/utils_tests/test_dependencies.py 87.5% <0.0%> (-12.5%) ⬇️
evalml/tests/component_tests/test_utils.py 98.3% <0.0%> (-1.7%) ⬇️
...ests/automl_tests/test_automl_search_regression.py 99.2% <0.0%> (-0.8%) ⬇️
...understanding_tests/test_permutation_importance.py 99.3% <0.0%> (-0.7%) ⬇️
evalml/utils/gen_utils.py 99.1% <0.0%> (-0.4%) ⬇️
evalml/tests/pipeline_tests/test_pipelines.py 99.6% <0.0%> (-0.4%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e561c7...36980e2. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the 1723-target-encoder-preserve-custom-index branch 3 times, most recently from cd0f318 to e3fd63f Compare February 12, 2021 15:39
@freddyaboulton freddyaboulton marked this pull request as ready for review February 12, 2021 16:17
@freddyaboulton freddyaboulton added the enhancement An improvement to an existing feature. label Feb 12, 2021
@@ -60,10 +60,6 @@ def __init__(self,
random_seed=random_seed)

def fit(self, X, y):
if isinstance(X, pd.DataFrame):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice and clean tests! 🥳

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@freddyaboulton freddyaboulton force-pushed the 1723-target-encoder-preserve-custom-index branch from e3fd63f to 36980e2 Compare February 12, 2021 18:21
@freddyaboulton freddyaboulton merged commit 0fe8bdd into main Feb 12, 2021
2 checks passed
@freddyaboulton freddyaboulton deleted the 1723-target-encoder-preserve-custom-index branch February 12, 2021 18:55
@chukarsten chukarsten mentioned this pull request Feb 23, 2021
@dsherry dsherry mentioned this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetEncoder: preserve custom row index
4 participants