Transformers and estimators preserve custom index - #1836
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
- Coverage 99.9% 99.8% -0.1%
=======================================
Files 255 255
Lines 20608 20655 +47
=======================================
+ Hits 20586 20607 +21
- Misses 22 48 +26
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1723-target-encoder-preserve-custom-index
branch
3 times, most recently
from
February 12, 2021 15:39
cd0f318 to
e3fd63f
Compare
freddyaboulton
marked this pull request as ready for review
February 12, 2021 16:17
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
chukarsten,
dsherry and
jeremyliweishih
February 12, 2021 16:17
angela97lin
reviewed
Feb 12, 2021
| random_seed=random_seed) | ||
|
|
||
| def fit(self, X, y): | ||
| if isinstance(X, pd.DataFrame): |
angela97lin
approved these changes
Feb 12, 2021
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
This looks great, nice and clean tests! 🥳
freddyaboulton
force-pushed
the
1723-target-encoder-preserve-custom-index
branch
from
February 12, 2021 18:21
e3fd63f to
36980e2
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1723
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.