New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformers and estimators preserve custom index #1836
Transformers and estimators preserve custom index #1836
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
- Coverage 99.9% 99.8% -0.1%
=======================================
Files 255 255
Lines 20608 20655 +47
=======================================
+ Hits 20586 20607 +21
- Misses 22 48 +26
Continue to review full report at Codecov.
|
cd0f318
to
e3fd63f
Compare
@@ -60,10 +60,6 @@ def __init__(self, | |||
random_seed=random_seed) | |||
|
|||
def fit(self, X, y): | |||
if isinstance(X, pd.DataFrame): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, nice and clean tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
e3fd63f
to
36980e2
Compare
Pull Request Description
Fixes #1723
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.