Conversation
ParthivNaresh
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 255 255
Lines 20644 20644
=======================================
Hits 20636 20636
Misses 8 8 Continue to review full report at Codecov.
|
# Conflicts: # .circleci/config.yml
ParthivNaresh
requested review from
angela97lin,
bchen1116,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
dsherry and
freddyaboulton
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@ParthivNaresh Looks good to me! Looks like the runtime for the windows tests is about 30 minutes which is about the same as circleci so I think it's a good idea to use 4 workers!
| run: | | ||
| . $env:USERPROFILE\Miniconda3\shell\condabin\conda-hook.ps1 | ||
| conda activate curr_py | ||
| pytest evalml/ -n 4 --doctest-modules --cov=evalml --junitxml=test-reports/junit.xml --doctest-continue-on-failure |
There was a problem hiding this comment.
Why not make this the win-git-test command?
There was a problem hiding this comment.
I had it like that previously and for some reason it had failed, changed it back now, thanks!
…alml into 1827-Windows-Unit-Tests
dsherry
left a comment
dsherry
left a comment
There was a problem hiding this comment.
Looks great, nice going!
| pytest evalml/ -n 8 --doctest-modules --cov=evalml --junitxml=test-reports/junit.xml --doctest-continue-on-failure -v | ||
| .PHONY: win-git-test | ||
| win-git-test: | ||
| pytest evalml/ -n 4 --doctest-modules --cov=evalml --junitxml=test-reports/junit.xml --doctest-continue-on-failure |
There was a problem hiding this comment.
@ParthivNaresh so this was enough to avoid the memory issues on the GH actions box?
I see the runtime of the two GH actions on this PR was about 33min. I also see the runtimes of the windows job on circleci on main has ranged from 28min-33min in the recent past. This makes me think by cutting the number of workers we're incurring a slight runtime cost, but its not as bad as I would've guessed. Seems acceptable. Sweet!
4 participants
Fixes #1827