Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow - Release Notes Updated #1849

Merged
merged 27 commits into from Feb 18, 2021
Merged

Conversation

ParthivNaresh
Copy link
Contributor

Fixes #1829

@ParthivNaresh ParthivNaresh self-assigned this Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1849 (2f97f12) into main (458fb40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1849   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         255      255           
  Lines       20644    20644           
=======================================
  Hits        20636    20636           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458fb40...2f97f12. Read the comment docs.

@ParthivNaresh ParthivNaresh requested review from dsherry and freddyaboulton and removed request for dsherry February 17, 2021 18:30
@ParthivNaresh
Copy link
Contributor Author

@dsherry I think we'll have to disable release_notes_updated in settings before merging

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh I think this looks good!


on:
pull_request:
types: [opened, synchronize]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no need to worry about main I think.

@ParthivNaresh ParthivNaresh merged commit f9156d1 into main Feb 18, 2021
@chukarsten chukarsten mentioned this pull request Feb 23, 2021
@dsherry dsherry mentioned this pull request Mar 10, 2021
@freddyaboulton freddyaboulton deleted the 1829-Release-Notes-Updated branch May 13, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions - Workflow - release_notes_updated
2 participants