Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing graphviz pin in windows ci #1851

Merged
merged 2 commits into from Feb 17, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1848


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1851 (a42e1da) into main (12a5456) will increase coverage by 67.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #1851      +/-   ##
========================================
+ Coverage   32.9%   99.9%   +67.0%     
========================================
  Files        255     255              
  Lines      20662   20662              
========================================
+ Hits        6795   20631   +13836     
+ Misses     13867      31   -13836     
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_dependencies.py 87.5% <0.0%> (+87.5%) ⬆️
evalml/tests/component_tests/test_utils.py 98.3% <0.0%> (+98.3%) ⬆️
...ests/automl_tests/test_automl_search_regression.py 99.2% <0.0%> (+99.2%) ⬆️
evalml/tests/component_tests/test_components.py 99.2% <0.0%> (+99.2%) ⬆️
...understanding_tests/test_permutation_importance.py 99.3% <0.0%> (+99.3%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.6% <0.0%> (+99.6%) ⬆️
.../automl_tests/test_automl_search_classification.py 99.7% <0.0%> (+99.7%) ⬆️
...lml/tests/model_understanding_tests/test_graphs.py 99.8% <0.0%> (+99.8%) ⬆️
evalml/__main__.py 100.0% <0.0%> (+100.0%) ⬆️
evalml/tests/utils_tests/test_logger.py 100.0% <0.0%> (+100.0%) ⬆️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a5456...a42e1da. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@freddyaboulton freddyaboulton force-pushed the unpin-graphviz-windows-unit-tests branch from d521221 to a42e1da Compare February 17, 2021 18:36
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎈

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@freddyaboulton freddyaboulton merged commit 1c6156c into main Feb 17, 2021
@freddyaboulton freddyaboulton deleted the unpin-graphviz-windows-unit-tests branch February 17, 2021 21:01
@chukarsten chukarsten mentioned this pull request Feb 23, 2021
@dsherry dsherry mentioned this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncap conda graphviz version for windows install
4 participants