Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidTargetDataCheck: if y is None, return data check error instead of raising exception #1866

Merged
merged 12 commits into from Feb 22, 2021
Merged

InvalidTargetDataCheck: if y is None, return data check error instead of raising exception #1866

merged 12 commits into from Feb 22, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #1820

@angela97lin angela97lin marked this pull request as draft February 19, 2021 22:00
@codecov
Copy link

codecov bot commented Feb 19, 2021 •
edited

Codecov Report

Merging #1866 (de8c1f3) into main (542b828) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1866   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         260      260           
  Lines       20892    20893    +1     
=======================================
+ Hits        20886    20887    +1     
  Misses          6        6
Impacted Files Coverage Δ
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <100.0%> (ø)
...ta_checks_tests/test_invalid_targets_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542b828...de8c1f3. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review February 22, 2021 15:50
@angela97lin angela97lin changed the title InvalidTargetDataCheck: if y is None, raise data check error InvalidTargetDataCheck: if y is None, return data check error Feb 22, 2021
@angela97lin angela97lin changed the title InvalidTargetDataCheck: if y is None, return data check error InvalidTargetDataCheck: if y is None, return data check error instead of raising exception Feb 22, 2021
jeremyliweishih
jeremyliweishih approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

bchen1116
bchen1116 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

freddyaboulton
freddyaboulton approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin !!

chukarsten
chukarsten approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angela, looks good.

evalml/pipelines/pipeline_base_meta.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit 31f9226 into main Feb 22, 2021
@angela97lin angela97lin deleted the 1820_invalid_y branch February 22, 2021 22:15
@chukarsten chukarsten mentioned this pull request Feb 23, 2021
Merged
@angela97lin angela97lin added this to the Sprint 2021 Feb B milestone Mar 4, 2021
@dsherry dsherry mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@chukarsten chukarsten chukarsten approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
Sprint 2021 Feb B
Development

Successfully merging this pull request may close these issues.

InvalidTargetDataCheck: if y is None, raise data check error
5 participants
@angela97lin @jeremyliweishih @bchen1116 @freddyaboulton @chukarsten