Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for string max_times #189

Merged
merged 4 commits into from Nov 7, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Nov 6, 2019

Added additional documentation to show updated max_time functionality. Made it clear that it is possible for max_time to only be set and for it to take in a string.

Resolves #177

kmax12
kmax12 previously approved these changes Nov 7, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

looks good minus the new warning message

"name": "stderr",
"output_type": "stream",
"text": [
"/Users/christopher.bunn/dev_envs/evalml/lib/python3.7/site-packages/sklearn/externals/joblib/__init__.py:15: DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.\n",
Copy link
Contributor

@kmax12 kmax12 Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why this warning is poping up now, but not before? i know @jeremyliweishih was dealing with some warning problems earlier, but this might be a different one

Copy link
Contributor

@jeremyliweishih jeremyliweishih Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same problem, the order of imports changed in __init__.py.

@christopherbunn can you move this block to the top after import warnings and see if it helps?

with warnings.catch_warnings():
    warnings.simplefilter("ignore", DeprecationWarning)
    import skopt

Copy link
Contributor Author

@christopherbunn christopherbunn Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving it up fixed it, just pushed the changes.

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          91       91           
  Lines        2328     2328           
=======================================
  Hits         2251     2251           
  Misses         77       77
Impacted Files Coverage Δ
evalml/models/auto_regressor.py 90.9% <ø> (ø) ⬆️
evalml/models/auto_classifier.py 100% <ø> (ø) ⬆️
evalml/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d079d...0bc3614. Read the comment docs.

@christopherbunn christopherbunn merged commit 41115b2 into master Nov 7, 2019
@christopherbunn christopherbunn deleted the unlim-pipelines-doc branch Nov 7, 2019
@angela97lin angela97lin mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for unlimited pipelines feature
3 participants