Updated documentation for string max_times #189
Conversation
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "/Users/christopher.bunn/dev_envs/evalml/lib/python3.7/site-packages/sklearn/externals/joblib/__init__.py:15: DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.\n", |
There was a problem hiding this comment.
any idea why this warning is poping up now, but not before? i know @jeremyliweishih was dealing with some warning problems earlier, but this might be a different one
There was a problem hiding this comment.
I think it's the same problem, the order of imports changed in __init__.py.
@christopherbunn can you move this block to the top after import warnings and see if it helps?
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
import skopt
There was a problem hiding this comment.
Moving it up fixed it, just pushed the changes.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 91 91
Lines 2328 2328
=======================================
Hits 2251 2251
Misses 77 77
Continue to review full report at Codecov.
|
Added additional documentation to show updated
max_timefunctionality. Made it clear that it is possible formax_timeto only be set and for it to take in a string.Resolves #177