Skip to content

Conversation

@angela97lin
Copy link
Contributor

Closes #1878

@angela97lin angela97lin self-assigned this Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1896 (f89cce1) into main (b80cd3e) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1896     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         263      266      +3     
  Lines       21299    21348     +49     
=========================================
+ Hits        21293    21342     +49     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/data_checks/__init__.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check_action.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check_action_code.py 100.0% <100.0%> (ø)
.../tests/data_checks_tests/test_data_check_action.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80cd3e...f89cce1. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review February 26, 2021 16:04
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin I think this is great!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I agree with Freddy's suggestions though, it would be nice to default to the empty dict and return the string for the user.

@angela97lin angela97lin merged commit eb3bf8f into main Mar 1, 2021
@angela97lin angela97lin deleted the 1878_data_check_action branch March 1, 2021 07:43
@angela97lin angela97lin added this to the Sprint 2021 Feb B milestone Mar 4, 2021
@dsherry dsherry mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DataCheckAction class

3 participants