Update Woodwork to 0.0.10#1900
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 263 263
Lines 21300 21299 -1
=======================================
- Hits 21294 21293 -1
Misses 6 6
Continue to review full report at Codecov.
|
| ... 'y': [13, 5, 13, 74, 24], | ||
| ... }) | ||
| >>> y = pd.Series([10, 42, 31, 51, 40]) | ||
| >>> y = pd.Series([10, 42, 31, 51, 42]) |
Contributor
There was a problem hiding this comment.
I saw your comment about how woodwork will not calculate mutual information if one of the columns has all unique values. I guess that means that the mutual information is 0 in that case.
Does this mean we should update the DefaultDataChecks to use method='pearson' for regression? Columns can still be 95% correlated with the target if the target is all unique.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1899
Changes made in
0.0.10tomutual_information(alteryx/woodwork#563) s.t. columns which have completely unique values are no longer considered. Hence, had to tweak some of our tests so that the return values were as expected.