Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woodwork to 0.0.10 #1900

Merged
merged 3 commits into from Feb 26, 2021
Merged

Update Woodwork to 0.0.10 #1900

merged 3 commits into from Feb 26, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Feb 25, 2021

Closes #1899

Changes made in 0.0.10 to mutual_information (alteryx/woodwork#563) s.t. columns which have completely unique values are no longer considered. Hence, had to tweak some of our tests so that the return values were as expected.

@angela97lin angela97lin self-assigned this Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1900 (bbf68e7) into main (7b400c8) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1900   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         263      263           
  Lines       21300    21299    -1     
=======================================
- Hits        21294    21293    -1     
  Misses          6        6           
Impacted Files Coverage Δ
evalml/data_checks/target_leakage_data_check.py 100.0% <ø> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <100.0%> (ø)
..._checks_tests/test_multicollinearity_data_check.py 100.0% <100.0%> (ø)
...ata_checks_tests/test_target_leakage_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b400c8...bbf68e7. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review February 26, 2021 19:38
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angela97lin angela97lin merged commit 1d50f96 into main Feb 26, 2021
@angela97lin angela97lin deleted the 1899_ww branch February 26, 2021 21:26
... 'x': [42, 54, 12, 64, 12],
... 'y': [13, 5, 13, 74, 24],
... })
>>> y = pd.Series([10, 42, 31, 51, 40])
>>> y = pd.Series([10, 42, 31, 51, 42])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your comment about how woodwork will not calculate mutual information if one of the columns has all unique values. I guess that means that the mutual information is 0 in that case.

Does this mean we should update the DefaultDataChecks to use method='pearson' for regression? Columns can still be 95% correlated with the target if the target is all unique.

@angela97lin angela97lin added this to the Sprint 2021 Feb B milestone Mar 4, 2021
@dsherry dsherry mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Woodwork to 0.0.10
3 participants