-
Notifications
You must be signed in to change notification settings - Fork 89
Removing explain_prediction #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1746f9
to
f3a4abc
Compare
@@ -28,213 +26,6 @@ def compare_two_tables(table_1, table_2): | |||
assert row.strip().split() == row_answer.strip().split() | |||
|
|||
|
|||
test_features = [[1], np.ones((15, 1)), pd.DataFrame({"a": [1, 2, 3], "b": [1, 2, 3]}).iloc[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have coverage in test_explain_predictions_best_worst_and_explain_predictions
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 267 267
Lines 21715 21664 -51
=========================================
- Hits 21709 21658 -51
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice, thanks for coming back to this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
f3a4abc
to
6816c35
Compare
6816c35
to
8fc399b
Compare
Pull Request Description
Fixes #1832
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.