Removing explain_prediction #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
force-pushed
the
1832-remove-explain-prediction
branch
from
b1746f9 to
f3a4abc
Compare
freddyaboulton
commented
Mar 3, 2021
| @@ -28,213 +26,6 @@ def compare_two_tables(table_1, table_2): | |||
| assert row.strip().split() == row_answer.strip().split() | |||
|
|
|||
|
|
|||
| test_features = [[1], np.ones((15, 1)), pd.DataFrame({"a": [1, 2, 3], "b": [1, 2, 3]}).iloc[0], | |||
There was a problem hiding this comment.
We have coverage in test_explain_predictions_best_worst_and_explain_predictions
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 267 267
Lines 21715 21664 -51
=========================================
- Hits 21709 21658 -51
Misses 6 6
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
chukarsten,
dsherry,
angela97lin,
bchen1116,
jeremyliweishih and
ParthivNaresh
angela97lin
approved these changes
Mar 3, 2021
freddyaboulton
force-pushed
the
1832-remove-explain-prediction
branch
from
f3a4abc to
6816c35
Compare
freddyaboulton
force-pushed
the
1832-remove-explain-prediction
branch
from
6816c35 to
8fc399b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1832
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.