Skip to content

Removing explain_prediction - #1915

Merged
freddyaboulton merged 2 commits into
mainfrom
1832-remove-explain-prediction
Mar 3, 2021
Merged

freddyaboulton merged 2 commits into
mainfrom
1832-remove-explain-prediction

Conversation

@freddyaboulton

Copy link
Copy Markdown
Contributor

Pull Request Description

Fixes #1832


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton self-assigned this Mar 2, 2021
@freddyaboulton
freddyaboulton force-pushed the 1832-remove-explain-prediction branch from b1746f9 to f3a4abc Compare March 3, 2021 15:08
assert row.strip().split() == row_answer.strip().split()


test_features = [[1], np.ones((15, 1)), pd.DataFrame({"a": [1, 2, 3], "b": [1, 2, 3]}).iloc[0],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have coverage in test_explain_predictions_best_worst_and_explain_predictions

@codecov

codecov Bot commented Mar 3, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1915 (8fc399b) into main (7ff8435) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1915     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         267      267             
  Lines       21715    21664     -51     
=========================================
- Hits        21709    21658     -51     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/model_understanding/__init__.py 100.0% <ø> (ø)
...nderstanding/prediction_explanations/explainers.py 100.0% <ø> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.0% <ø> (ø)
..._understanding/prediction_explanations/__init__.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff8435...8fc399b. Read the comment docs.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM

@angela97lin angela97lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, thanks for coming back to this!

@bchen1116 bchen1116 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@freddyaboulton
freddyaboulton force-pushed the 1832-remove-explain-prediction branch from f3a4abc to 6816c35 Compare March 3, 2021 19:25
@freddyaboulton
freddyaboulton force-pushed the 1832-remove-explain-prediction branch from 6816c35 to 8fc399b Compare March 3, 2021 21:53
@freddyaboulton
freddyaboulton merged commit e761749 into main Mar 3, 2021
@freddyaboulton
freddyaboulton deleted the 1832-remove-explain-prediction branch March 3, 2021 22:57
@dsherry dsherry mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove explain_prediction()

4 participants