Skip to content

Conversation

@angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 2, 2021

Closes #1880

Note that this does not actually populate the actions returned. That'll be done in #1881 to prevent a PR with too many logic changes + API changes. This just updates the API!

Internally, we were returning messages--updated this to results (open to a better name if anyone has one) to indicate that its no longer just messages that we're returning from validate :)

@angela97lin angela97lin self-assigned this Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1916 (3396057) into main (d0b6101) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         267      267           
  Lines       21699    21700    +1     
=======================================
+ Hits        21693    21694    +1     
  Misses          6        6           
Impacted Files Coverage Δ
...ests/data_checks_tests/test_sparsity_data_check.py 100.0% <ø> (ø)
...ts/data_checks_tests/test_uniqueness_data_check.py 100.0% <ø> (ø)
evalml/data_checks/class_imbalance_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/data_checks.py 100.0% <100.0%> (ø)
evalml/data_checks/high_variance_cv_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/highly_null_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/multicollinearity_data_check.py 100.0% <100.0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b6101...3396057. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review March 3, 2021 20:44
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Changes look good to me!

@angela97lin angela97lin merged commit 5051e67 into main Mar 4, 2021
@angela97lin angela97lin deleted the 1880_data_checks_actions branch March 4, 2021 17:59
@angela97lin angela97lin added this to the Sprint 2021 Feb B milestone Mar 4, 2021
@dsherry dsherry mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all DataCheck / DataChecks validate method to include a “action” key

3 participants