Repository navigation
Demo of Two-way Part Dep Plots - #1919
Conversation
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "partial_dependence(pipeline, X, features=('worst perimeter', 'worst radius'))" |
There was a problem hiding this comment.
I'm not sure why, but the two-way partial dependence calculation takes longer than the graph_partial_dependence function, which, iirc, calls partial_dependence. It takes a fair amount of time...5 minutes? We would be accepting an increase to the build_docs runtime.
There was a problem hiding this comment.
I think if we set grid_resolution=20 it should take a lot less time (it's what the graph_partial_dependence call below is doing.)
I believe this scales quadratically with the grid size in the two-way case and if so we should make a note of it here and/or the docstring.
| assert np.array_equal(data['y'], mock_cb_thresholds.return_value['score']) | ||
|
|
||
|
|
||
| def check_partial_dependence_dataframe(pipeline, part_dep, grid_size=20): |
There was a problem hiding this comment.
Moved the partial_dependence tests over to their own file for organizational purposes.
freddyaboulton
left a comment
There was a problem hiding this comment.
@chukarsten Looks good! I left a comment about using a smaller grid size in the notebook to speed it up.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "partial_dependence(pipeline, X, features=('worst perimeter', 'worst radius'))" |
There was a problem hiding this comment.
I think if we set grid_resolution=20 it should take a lot less time (it's what the graph_partial_dependence call below is doing.)
I believe this scales quadratically with the grid size in the two-way case and if so we should make a note of it here and/or the docstring.
74ceb79 to
5ba4a70
Compare
Codecov Report
@@ Coverage Diff @@
## main #1919 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 265 266 +1
Lines 21936 21959 +23
=========================================
+ Hits 21930 21953 +23
Misses 6 6
Continue to review full report at Codecov.
|
ec12a57 to
5154054
Compare
Addresses #1835
Added some updates to the model_understanding.ipynb!