Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow - Detect dependency changes #1933

Merged
merged 13 commits into from
Mar 8, 2021
Merged

Conversation

ParthivNaresh
Copy link
Contributor

Fixes #1926

@ParthivNaresh ParthivNaresh self-assigned this Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1933 (6c0c935) into main (9bab6f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         265      265           
  Lines       21712    21712           
=======================================
  Hits        21706    21706           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bab6f8...6c0c935. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review March 5, 2021 16:39
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh looks good!

I see we're dumping the diff into the job output instead of saving it as an artifact. Fine by me.

One test I'd recommend you run before we merge, if you haven't already:

  • Put up a separate draft PR with a branch based off this one
  • On that branch, edit latest_dependency_versions.txt such that the deps update check should fail
  • Verify that it fails
    Sound good?

export DEPENDENCY_FILE_PATH=/tmp/dependencies_updated_artifacts/current_dependencies.txt
evalml/tests/dependency_update_check/make_deps_diff.sh
diff evalml/tests/dependency_update_check/latest_dependency_versions.txt /tmp/dependencies_updated_artifacts/current_dependencies.txt > /tmp/dependencies_updated_artifacts/diff.txt
exit $?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh will GH actions error out if this error code is nonzero? That was the case with circleci, just confirming that'll work for GH too. If not, we should change this to make sure we get an error when there is a non-empty diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/detect_changes.yml Show resolved Hide resolved
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ParthivNaresh ParthivNaresh merged commit 9f1e5a2 into main Mar 8, 2021
@dsherry dsherry mentioned this pull request Mar 11, 2021
@freddyaboulton freddyaboulton deleted the 1926-Dependencies-Update branch May 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Check Dependencies for Updates to GitHub Actions
4 participants