Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params to the data splitter for visibility #1966

merged 5 commits into from Mar 12, 2021


Copy link

With this change, when we call automl.data_splitter, we will see

BalancedClassificationDataCVSplit(balanced_ratio=4, min_percentage=0.1,
                 min_samples=100, n_splits=3, random_seed=0, shuffle=True)

rather than

BalancedClassificationDataCVSplit(balanced_ratio=None, min_percentage=None,
                 min_samples=None, n_splits=3, random_seed=0, shuffle=True)

@bchen1116 bchen1116 self-assigned this Mar 11, 2021
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1966 (6a1c537) into main (064b821) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1966     +/-   ##
+ Coverage   100.0%   100.0%   +0.1%     
  Files         273      273             
  Lines       22391    22406     +15     
+ Hits        22385    22400     +15     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/tests/automl_tests/ 100.0% <ø> (ø)
...data_splitters/ 100.0% <100.0%> (ø)
...ests/ 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064b821...6a1c537. Read the comment docs.

Copy link

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding correctly, the test in evalml/tests/automl_tests/ tests this updated change, and then the test you added in evalml/tests/preprocessing_tests/ is just to check for defaults / set attributes? LGTM!

@bchen1116 bchen1116 merged commit 10297a2 into main Mar 12, 2021
12 checks passed
@dsherry dsherry mentioned this pull request Mar 24, 2021
@freddyaboulton freddyaboulton deleted the bc_datasplit_params branch May 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants