Skip to content

Add params to the data splitter for visibility - #1966

Merged
bchen1116 merged 5 commits into
mainfrom
bc_datasplit_params
Mar 12, 2021
Merged

Add params to the data splitter for visibility#1966
bchen1116 merged 5 commits into
mainfrom
bc_datasplit_params

Conversation

@bchen1116

Copy link
Copy Markdown
Contributor

With this change, when we call automl.data_splitter, we will see

BalancedClassificationDataCVSplit(balanced_ratio=4, min_percentage=0.1,
                 min_samples=100, n_splits=3, random_seed=0, shuffle=True)

rather than

BalancedClassificationDataCVSplit(balanced_ratio=None, min_percentage=None,
                 min_samples=None, n_splits=3, random_seed=0, shuffle=True)

@bchen1116 bchen1116 self-assigned this Mar 11, 2021
@codecov

codecov Bot commented Mar 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1966 (6a1c537) into main (064b821) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1966     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         273      273             
  Lines       22391    22406     +15     
=========================================
+ Hits        22385    22400     +15     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/tests/automl_tests/test_automl.py 100.0% <ø> (ø)
...data_splitters/balanced_classification_splitter.py 100.0% <100.0%> (ø)
...ests/test_balanced_classification_data_splitter.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064b821...6a1c537. Read the comment docs.

@angela97lin angela97lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding correctly, the test in evalml/tests/automl_tests/test_automl.py tests this updated change, and then the test you added in evalml/tests/preprocessing_tests/test_balanced_classification_data_splitter.py is just to check for defaults / set attributes? LGTM!

@bchen1116
bchen1116 merged commit 10297a2 into main Mar 12, 2021
@dsherry dsherry mentioned this pull request Mar 24, 2021
@freddyaboulton
freddyaboulton deleted the bc_datasplit_params branch May 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants