Add params to the data splitter for visibility - #1966
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1966 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 273 273
Lines 22391 22406 +15
=========================================
+ Hits 22385 22400 +15
Misses 6 6
Continue to review full report at Codecov.
|
bchen1116
requested review from
ParthivNaresh,
angela97lin,
christopherbunn,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
dsherry and
freddyaboulton
March 11, 2021 20:14
angela97lin
approved these changes
Mar 11, 2021
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
If I'm understanding correctly, the test in evalml/tests/automl_tests/test_automl.py tests this updated change, and then the test you added in evalml/tests/preprocessing_tests/test_balanced_classification_data_splitter.py is just to check for defaults / set attributes? LGTM!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, when we call
automl.data_splitter, we will seerather than