Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add Imputer to make_pipeline if no numeric / categorical columns #1967

merged 4 commits into from Mar 11, 2021


Copy link

Closes #1938

@angela97lin angela97lin self-assigned this Mar 11, 2021
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1967 (a056dae) into main (80267d7) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1967     +/-   ##
+ Coverage   100.0%   100.0%   +0.1%     
  Files         273      273             
  Lines       22339    22391     +52     
+ Hits        22333    22385     +52     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/pipelines/ 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/ 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80267d7...a056dae. Read the comment docs.

Copy link

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin This looks good to me!

Copy link
Contributor Author

@freddyaboulton Dang, you're speedymcspeedster at reviewing! 😂
I didn't even realize I made it a non-draft PR, thanks a lot! 🥳

@angela97lin angela97lin merged commit 440a944 into main Mar 11, 2021
13 checks passed
@angela97lin angela97lin deleted the 1938_no_imputer branch March 11, 2021 20:58
@dsherry dsherry mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Don't add Imputer to make_pipeline if no numeric / categorical columns
2 participants