Include recommended actions for each data check's set of actions #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela97lin
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 273 273
Lines 22356 22381 +25
=========================================
+ Hits 22350 22375 +25
Misses 6 6
Continue to review full report at Codecov.
|
angela97lin
commented
Mar 15, 2021
|
|
||
| # test 2D list | ||
| assert highly_null_check.validate([[None, None, None, None, 0], [None, None, None, "hi", 5]]) == { |
There was a problem hiding this comment.
Just cleaning up. We were using the same expected value for each of these cases.
angela97lin
requested review from
bchen1116,
freddyaboulton,
dsherry,
chukarsten,
jeremyliweishih and
ParthivNaresh
bchen1116
approved these changes
Mar 16, 2021
|
|
||
| # test 2D list | ||
| assert highly_null_check.validate([[None, None, None, None, 0], [None, None, None, "hi", 5]]) == { |
|
|
||
| new_actions = messages_new["actions"] | ||
| for new_action in new_actions: | ||
| if new_action not in messages["actions"]: |
chukarsten
approved these changes
Mar 16, 2021
|
@chukarsten There's no better way to spend time than to write more unit tests 😂 Thanks for the suggestion, added! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #1881.
Addresses:
DataChecksUniquenessDataCheckSparsityDataCheckTargetLeakageDataCheckHighlyNullDataCheckIDColumnsDataCheckNoVarianceDataCheckThese data checks are relatively simple as their recommended action is just to drop the problem column.
Currently, different data checks could result in the same data check action (drop a specific col). Should the
DataChecksclass address this and remove duplicates?In this PR, I address this question with "yes", because I imagine this will be useful when creating components--we don't want the second DropColumns component to error out when it can't find the column, but open to thoughts / concerns! Note that this doesn't affect different transformations on the same col (impute then drop).