Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build_docs CI job in favor of RTD GH builder #1974

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Mar 12, 2021

We were waiting on resolution of an RTD builder bug (timeout after ~60sec). Not resolved yet, but rerunning seems to fix that typically, so I think its time!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1974 (061bc2b) into main (440a944) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         273      273           
  Lines       22391    22391           
=======================================
  Hits        22385    22385           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440a944...061bc2b. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete install_dependencies_docs under the commands section on line 35 if you want, no big deal otherwise!

@dsherry dsherry merged commit 064b821 into main Mar 12, 2021
@dsherry dsherry deleted the ds_remove_build_docs branch March 12, 2021 17:09
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants