Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Random State Argument #1985

Merged
merged 7 commits into from Mar 17, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1834


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1985 (6cd74f7) into main (cf93929) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1985     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         274      274             
  Lines       22418    22286    -132     
=========================================
- Hits        22412    22280    -132     
  Misses          6        6             
Impacted Files Coverage Δ
evalml/automl/automl_algorithm/automl_algorithm.py 100.0% <ø> (ø)
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <ø> (ø)
...components/ensemble/stacked_ensemble_classifier.py 100.0% <ø> (ø)
.../components/ensemble/stacked_ensemble_regressor.py 100.0% <ø> (ø)
...ents/estimators/classifiers/catboost_classifier.py 100.0% <ø> (ø)
...estimators/classifiers/decision_tree_classifier.py 100.0% <ø> (ø)
...components/estimators/classifiers/et_classifier.py 100.0% <ø> (ø)
...ts/estimators/classifiers/kneighbors_classifier.py 100.0% <ø> (ø)
...ents/estimators/classifiers/lightgbm_classifier.py 100.0% <ø> (ø)
...omponents/estimators/classifiers/svm_classifier.py 100.0% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf93929...6cd74f7. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment that's not pertaining to changes you've made but noticed that random_seed was missing as a parameter in the docstrings for some transformers--would be good to add them in 😀

@@ -72,7 +71,6 @@ def __init__(self,
self._encoder = None
super().__init__(parameters=parameters,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add random_seed to the docstrings for parameters 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -56,7 +55,6 @@ def __init__(self,
category_encode = import_or_raise('category_encoders', error_msg='category_encoders not installed. Please install using `pip install category_encoders`')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, since random_seed is missing, can we add it to the docstring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some comments on some missed documentation edits, but good job hunting all of these down 😅

"""Extracts features from text columns using featuretools' nlp_primitives

Arguments:
random_state (None, int): Deprecated - use random_seed instead.
random_seed (int): Seed for the random number generator. Defaults to 0.
"""
random_seed = deprecate_arg("random_state", "random_seed", random_state, random_seed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove doc for random_state

@@ -7,7 +7,7 @@
class TextTransformer(Transformer):
"""Base class for all transformers working with text features"""

def __init__(self, component_obj=None, random_state=None, random_seed=0, **kwargs):
def __init__(self, component_obj=None, random_seed=0, **kwargs):
"""Creates a transformer to perform TF-IDF transformation and Singular Value Decomposition for text columns.

Arguments:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove doc for random_state

evalml/pipelines/time_series_classification_pipelines.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@freddyaboulton freddyaboulton merged commit 2afdc84 into main Mar 17, 2021
@freddyaboulton freddyaboulton deleted the 1834-delete-random-state-arg branch March 17, 2021 23:14
@dsherry dsherry mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete random_state argument and warnings
4 participants