Support for Multiclass Classification in Class Imbalance data checks - #1986
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1986 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 274 274
Lines 22286 22299 +13
=========================================
+ Hits 22280 22293 +13
Misses 6 6
Continue to review full report at Codecov.
|
bchen1116
commented
Mar 16, 2021
bchen1116
requested review from
ParthivNaresh,
angela97lin,
christopherbunn,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
angela97lin and
dsherry
March 16, 2021 21:33
bchen1116
marked this pull request as ready for review
March 16, 2021 21:33
dsherry
approved these changes
Mar 17, 2021
dsherry
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I left a couple impl comments
angela97lin
approved these changes
Mar 17, 2021
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Neat, I'm a big fan of this improvement! LGTM 🥳
ParthivNaresh
approved these changes
Mar 18, 2021
ParthivNaresh
left a comment
Contributor
There was a problem hiding this comment.
Very cleanly done, I love it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1864
Summary:
Did not incorporate steps for number of classes in order to keep this data check a little simpler and keep the logic in line with what users would expect. (ie at larger numbers of classes, we don't automatically lower the threshold, even though it might be imbalanced for the model to learn).