Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woodwork requirement to 0.0.11 #1996

Merged
merged 4 commits into from Mar 18, 2021
Merged

Update Woodwork requirement to 0.0.11 #1996

merged 4 commits into from Mar 18, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 18, 2021

Closes #1980

I reverted all tests to pre-Woodwork 0.0.10, where we had unique cols. Not super necessary but nice since if any changes happen again, these tests will fail :)

(Changes reverted are from this PR: 1d50f96)

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1996 (7214ef1) into main (372f753) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         274      274           
  Lines       22299    22300    +1     
=======================================
+ Hits        22293    22294    +1     
  Misses          6        6           
Impacted Files Coverage Δ
evalml/data_checks/target_leakage_data_check.py 100.0% <ø> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <100.0%> (ø)
..._checks_tests/test_multicollinearity_data_check.py 100.0% <100.0%> (ø)
...ata_checks_tests/test_target_leakage_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372f753...7214ef1. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks great! Thanks for fixing 😄

@angela97lin angela97lin merged commit 50da6bc into main Mar 18, 2021
@angela97lin angela97lin deleted the 1980_ww branch March 18, 2021 20:49
@dsherry dsherry mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Woodwork to 0.0.11
2 participants