New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lists as acceptable hyperparameter ranges in AutoMLSearch
#2028
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2028 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 278 278
Lines 22761 22759 -2
=======================================
- Hits 22752 22750 -2
Misses 9 9
Continue to review full report at Codecov.
|
AutoMLSearch
AutoMLSearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 Thanks for pointing these out, I had no idea we had doc examples of this. Removed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @angela97lin !!
@@ -283,17 +283,18 @@ def test_iterative_algorithm_stacked_ensemble_n_jobs_regression(n_jobs, linear_r | |||
assert seen_ensemble | |||
|
|||
|
|||
@pytest.mark.parametrize("parameters", [1, "hello", 1.3, -1.0006, [1, 3, 4], (2, 3, 4)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still keep a list example so that we can verify the IterativeAlgorithm now handles them properly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddyaboulton Correct me if I'm misunderstanding but the idea now is that we don't support lists so they shouldn't be handled correctly / are expected to error, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about the Drop Columns case for the data check actions. We would specify the columns to drop in the pipeline_params
of the IterativeAlgorithm
(at least that's the impl in #1981). So we can still pass lists it's just that the IterativeAlgorithm
shouldn't do anything to that list and just pass it to the pipeline in the parameters dict.
Closes #2015
To support lists as parameters for our components, we are removing lists as acceptable hyperparameter ranges in the
pipeline_parameters
parameter toAutoMLSearch
. This is okay, because users can still useskopt.space.Categorical
to achieve the same functionality.