-
Notifications
You must be signed in to change notification settings - Fork 91
Raise Error when Stacked Ensemble is passed to explain_predictions #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2033 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 278 278
Lines 22714 22748 +34
=========================================
+ Hits 22705 22739 +34
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bchen1116 !! This looks great.
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - maybe adding coverage for multiclass or time series would be good but not blocking.
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just had a comment about the fixtures; they're defined as pipelines but are actually estimators?
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, friendo!
fix #1863