Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoMLSearch.train_pipelines not applying undersampling #2038

Merged
merged 9 commits into from Mar 29, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #1987

@angela97lin angela97lin self-assigned this Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2038 (1e54228) into main (eb008b3) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2038     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         280      280             
  Lines       23047    22907    -140     
=========================================
- Hits        23038    22898    -140     
  Misses          9        9             
Impacted Files Coverage Δ
evalml/automl/engine/sequential_engine.py 100.0% <100.0%> (ø)
...valml/tests/automl_tests/test_sequential_engine.py 100.0% <100.0%> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb008b3...1e54228. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice and succinct ;)

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 66da502 into main Mar 29, 2021
@angela97lin angela97lin deleted the 1987_train_indices branch March 29, 2021 22:39
@chukarsten chukarsten mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoMLSearch.train_pipelines does not apply undersampling
4 participants